<html>
<head><meta charset="utf-8"><title>pubgrub#46 · t-cargo/PubGrub · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/index.html">t-cargo/PubGrub</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/pubgrub.2346.html">pubgrub#46</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="214434271"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/pubgrub%2346/near/214434271" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/pubgrub.2346.html#214434271">(Oct 24 2020 at 15:49)</a>:</h4>
<p>Currently the only thing holding back <a href="https://github.com/mpizenberg/pubgrub-rs/issues/46">pubgrub#46</a> is naming. I thought discussing it in chat platform may be easier than on Github.</p>
<p><code>AllowedVersions</code> should be changed to <code>Dependencies</code> per <span class="user-mention" data-user-id="348419">@Matthieu Pizenberg</span>  suggestion<br>
Current <code>Dependencies</code> enum should be changed to ???. It is a replacement for what previously was Option, and contains either <code>Unavailable</code> or <code>Known(AllowedVersions)</code> variants.</p>
<p>Does anyone have suggestions for that enum naming?</p>



<a name="214434989"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/pubgrub%2346/near/214434989" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/pubgrub.2346.html#214434989">(Oct 24 2020 at 16:04)</a>:</h4>
<p>Hey sorry, with family again this weekend. I'll try detailing a bit more next review with a global review. First one wasmostly saying what my thoughts were when reading commits one after the other</p>



<a name="214435157"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/pubgrub%2346/near/214435157" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/pubgrub.2346.html#214435157">(Oct 24 2020 at 16:08)</a>:</h4>
<p>No worries, I think you've done a wonderful job. I was just posting here to see if anyone else had some ideas on naming, which is usually a topic everyone can participate in <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="214436620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/pubgrub%2346/near/214436620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/pubgrub.2346.html#214436620">(Oct 24 2020 at 16:38)</a>:</h4>
<p>Enjoy the time with your family! And thank you for the consistently careful reviews.<br>
Also how is this affected by a redesign like <a href="https://github.com/mpizenberg/pubgrub-rs/issues/50">pubgrub#50</a>?</p>



<a name="214436832"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/pubgrub%2346/near/214436832" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/pubgrub.2346.html#214436832">(Oct 24 2020 at 16:42)</a>:</h4>
<blockquote>
<p>Also how is this affected by a redesign like <a href="https://github.com/mpizenberg/pubgrub-rs/issues/50">pubgrub#50</a>?</p>
</blockquote>
<p>There may be trivial conflicts, but we largely touched different parts of public API as far as I noticed.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>